[Bug 181979] Review Request: python-geoip - Python bindings for the GeoIP geographical lookup libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-geoip - Python bindings for the GeoIP geographical lookup libraries


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181979





------- Additional Comments From tibbs at math.uh.edu  2006-02-20 22:01 EST -------
Cool.  rpmlint is now silent and the name neets the guidelines.
The specfile is taken from the Python template and is clean.
There are no installed (non-doc) .py or .pyc files, so no .pyo files to ghost.
The source file matches upstream.
The license is appropriate, matches the spec and is included as %doc.

Absolutely minor nitpick: your Description: needs a period.
Somewhat less minor nitpick: Requires: GeoIP is redundant.  RPM picks up the
libGeoIP.so.1 requirement automatically.

Sorry I didn't catch those at first glance.  Fix them up and it's good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.