[Bug 169717] Review Request: Internode DSL usage applet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Internode DSL usage applet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169717


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |wart at kobold.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-02-22 02:46 EST -------
GOOD
====
* rpmlint output clean
* No redundance or not permissible BR:
* Source matches upstream
* Package name follows guidelines for gnome applets
* Builds on FC4-i386
* spec file legible, in Am. English
* macro use consistent
* code, not content
* No shared libraries or -devel package
* doc ok
* desktop file not needed
* Runs without crashing (did not test with a valid Internode account,
  however)

Recommended (but not required)
====
* Use %{SOURCE1} instead of {%_sourcedir}/COPYING
* Add %{?dist} to release tag
* GPL license ok, text included

* Does not build on FC5-i386 or FC4-x86_64.
* mock build not tested (my mock env. is hosed right now)

MUSTFIX:

* %exclude %{_bindir}/*.pyc %{_bindir}/*.pyo (comment #6)
* Requires: python-abi not needed for FC-5 (comment #2)
* Fix x86_64 build with respect to /usr/lib (comment #3)
* Does not own all directories that it creates:
  - %{python_sitelib}/internode/
  - %{datadir}/internode/
  - %{_libdir}/bonobo/servers (probably owned by a parent of one of the
    Requires, but was unable to verify)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.