[Bug 180897] Review Request: heartbeat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: heartbeat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180897





------- Additional Comments From orion at cora.nwra.com  2006-02-24 16:39 EST -------
Need:

Requires(post): /sbin/chkconfig
Requires(preun): /sbin/chkconfig

Change:

%{_libdir}/pils/plugins
to
%{_libdir}/pils/

so that it owns the directory and everything below.



You might want the devel files section to look like:

%{_includedir}/heartbeat/
%{_includedir}/clplumbing/
%{_includedir}/saf/
%{_includedir}/ocf/
%{_includedir}/stonith/
%{_includedir}/pils/

To be clear that they are directories.

Similar with %{_libdir}/stonith/

- Your *.so are duplicated in heartbeat and heartbeat-devel.  Change file lines
in heartbeat to:

%{_libdir}/libapphb.so.*

- Various programs are checked for a config time and not found:

checking for lynx... no
checking for ssh... no
checking for scp... no
checking for mail... no
checking for raidstart... no
checking for raidstop... no
checking for mdadm... no
checking for iptables... no
checking for md5... no
checking for drbdadm... no
checking for drbdsetup... no

I have no idea if this affects functionality or not...

- Is this important?

checking for owcimomd... no
configure: WARNING: Cimom not found, MOF will not be installed!

- Looks like the user ID might get hardcoded?

  HA user user id      = "17"

- Do you want to add snmp support?  Probably just needs BuildRequires:
net-snmp-devel.

  Build snmp subagent  = "no"
  SNMP libraries       = ""

Probably also need an enable flag and another subpackage.

- I think you need a BR: libtool-ltdl-devel , perhaps instead of BR: libtool (as
it seems to use $(top_builddir)/libtool in either case), to get:

  Use system LTDL      = "yes"


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.