[Bug 180897] Review Request: heartbeat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: heartbeat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180897





------- Additional Comments From orion at cora.nwra.com  2006-02-24 16:55 EST -------
# rpmlint -i heartbeat-devel
W: heartbeat-devel no-dependency-on heartbeat

Should have a Requires: heartbeat = %{version}-%{release} in the devel package
section.

# rpmlint -i heartbeat-ldirectord
W: heartbeat-ldirectord devel-file-in-non-devel-package
/usr/sbin/supervise-ldirectord-config
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.

E: heartbeat-ldirectord incoherent-logrotate-file /etc/logrotate.d/ldirectord
Your logrotate file should be named /etc/logrotate.d/<package name>.

W: heartbeat-ldirectord non-conffile-in-etc /etc/logrotate.d/ldirectord
A non-executable file in your package is being installed in /etc, but is not
a configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

E: heartbeat-ldirectord init-script-without-chkconfig-postin /etc/init.d/ldirectord
The package contains an init script but doesn't contain a %post with
a call to chkconfig.

E: heartbeat-ldirectord init-script-without-chkconfig-preun /etc/init.d/ldirectord
The package contains an init script but doesn't contain a %preun with
a call to chkconfig.

W: heartbeat-ldirectord service-default-enabled /etc/init.d/ldirectord
The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's chkconfig line to fix this if appropriate for this service.

E: heartbeat-ldirectord subsys-not-used /etc/init.d/ldirectord
While your daemon is running, you have to put a lock file in
/var/lock/subsys/. To see an example, look at this directory on your
machine and examine the corresponding init scripts.

W: heartbeat-ldirectord incoherent-init-script-name ldirectord
The init script name should be the same as the package name in lower case.


# rpmlint -i heartbeat-stonith
E: heartbeat-stonith library-without-ldconfig-postin /usr/lib/libapphb.so.0.0.0
This package contains a library and provides no %post scriptlet containing
a call to ldconfig.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.