[Bug 180897] Review Request: heartbeat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: heartbeat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180897





------- Additional Comments From fedora at soeterbroek.com  2006-02-28 17:02 EST -------
Spec Name or Url:
http://www.soeterbroek.com/linux/fedora/extras/heartbeat/heartbeat.spec
SRPM Name or Url:
http://www.soeterbroek.com/linux/fedora/extras/heartbeat/heartbeat-2.0.3-7.src.rpm 

* Tue Feb 28 2006  Joost Soeterbroek <fedora at soeterbroek.com> - 2.0.3-7
- fixed more rpmlint errors and warnings

remaining rpmlint issues:

W: heartbeat unstripped-binary-or-object /usr/bin/cl_status
- I do not know how to fix. Is this warning safe to ignore?

W: heartbeat dangling-symlink /etc/ha.d/resource.d/ldirectord /usr/sbin/ldirectord
The symbolic link points nowhere.
- I do not know how to fix. Is this warning safe to ignore?

W: heartbeat dangerous-command-in-%postun userdel
- I do not know how to fix. Is this warning safe to ignore?

W: heartbeat-ldirectord devel-file-in-non-devel-package
/usr/sbin/supervise-ldirectord-config
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.
- I think this is an error on the part of rpmlint. I can not 
  see any reason this file would be flagged as a 
  'development file', while it isn't.

E: heartbeat-ldirectord incoherent-logrotate-file /etc/logrotate.d/ldirectord
Your logrotate file should be named /etc/logrotate.d/<package name>.
- Agree with the error, but changing /etc/logrotate.d/ldirectord 
  to /etc/logrotate.d/heartbeat-ldirectord would mean changing a 
  lot of non-trivial things in source package. Can we safely ignore 
  this?

W: heartbeat-ldirectord incoherent-init-script-name ldirectord
The init script name should be the same as the package name in lower case.
- same as above. Can we safely ignore this?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.