[Bug 176613] Review Request: Nagios - System / network monitoring application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Nagios - System / network monitoring application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176613





------- Additional Comments From ivazquez at ivazquez.net  2006-01-04 00:07 EST -------
- Source0 should be http://dl.sourceforge.net/nagios/%{name}-%{version}.tar.gz
- Extra space on --libexecdir
- sed substitutions should be done in %build
- The sed substitution on p1.pl could be replaced with an insert (non-blocker)
- All of the files you list in the 2 %defattr sections (with the exception of
p1.pl) already have those permissions, so you can combine them and replace with
%defattr(-,root,root) and then merge redundant entries (e.g., %{_datadir}/%{name})
- The permissions on the doc dir are wrong, but I suspect that is because of the
%defattr
- %{_sysconfdir}/logrotate.d/nagios is not marked %config(noreplace)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.