[Bug 176943] Review Request: rootsh : Shell wrapper for auditing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rootsh : Shell wrapper for auditing


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176943





------- Additional Comments From jspaleta at gmail.com  2006-01-06 23:36 EST -------
Formal review
Summary: 1 blocker
- BAD: Forgot to include the COPYING file in the %docs section
Get that fixed and you have approval.


- GOOD: rpmlint on mock built binary returns clean.
- GOOD: package named according to the PackageNamingGuidelines.
- GOOD: The spec file name matches %{name}, in the format %{name}.spec
- GOOD: The package meets the PackagingGuidelines.
- GOOD: The package is licensed GPL
- GOOD: The License field in the package spec file matches the actual license.
- GOOD: The spec written in American English.
- GOOD: The spec file is legible. 
- GOOD: The sources used to build matches the upstream source
        md5sum  39e3a876b991fe235af3150335d1a0f8
- GOOD: The package successfully compile and build into binary rpms on atleast x86
- GOOD: No BuildRequires and it still builds in mock
- GOOD: No locales 
- GOOD: No shared library files 
- GOOD: own all directories that it creates. uses /usr/bin/ and
/usr/share/man/man1  which are explicitly listed in the FHS and owned by
filesystem package
- GOOD: no duplicates in %files listing.
- GOOD: Permissions on files are set properly. 
- GOOD: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
- GOOD: Each package must consistently use macros, as described in the macros
section of PackagingGuidelines.
- GOOD: The package must contain code, or permissable content. This is described
in detail in the code vs. content section of PackagingGuidelines.
- GOOD: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.