[Bug 176452] Review Request: oddjob - a D-BUS service which runs odd jobs on behalf of client applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: oddjob - a D-BUS service which runs odd jobs on behalf of client applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176452





------- Additional Comments From jspaleta at gmail.com  2006-01-07 11:29 EST -------
Looking over the specfile some more in context to the Packaging Guidelines...
<spec quote>
BuildPrereq: dbus-devel >= 0.22, libselinux-devel, libxml2-devel
BuildPrereq: pam-devel, python-devel
BuildPrereq: cyrus-sasl-devel, krb5-devel, openldap-devel
Prereq: /sbin/chkconfig
</quote>
Should the BuildPrereq tags be replaced with BuildRequires?
http://www.fedoraproject.org/wiki/PackagingGuidelines#head-c00c7e039df9f68a709ce2ceee6a5454edf16f8c

And should the Prereq for chkconfig in the scriptlets be cast as a pair of tags:
Requires(pre) Requires(post) since its called in both pre and post scriptlets?
http://www.fedoraproject.org/wiki/PackagingGuidelines#head-24e6fc168588eeaa2f8000bf5516fc56dcfcf461

And since you also use /sbin/service in the preun script don't you also need a
Requires(pre): /sbin/service ?


rpmlint on mock built packages returns with what looks like spurious errors:

rpmlint oddjob-0.21-2.i386.rpm
  E: oddjob executable-marked-as-config-file /etc/rc.d/init.d/oddjobd
  W: oddjob incoherent-init-script-name oddjobd
rpmlint oddjob-devel-0.21-2.i386.rpm
  W: oddjob-devel no-documentation
rpmlint oddjob-libs-0.21-2.i386.rpm
  returns clean

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.