[Bug 174377] Review Request:gnu-smalltalk - GNU Smalltalk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:gnu-smalltalk - GNU Smalltalk


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174377





------- Additional Comments From Jochen at herr-schmitt.de  2006-01-10 14:14 EST -------
> 1. /usr/bin/gst contains a invalid rpath.

Added --disable-rpath

> 2. Disable building the static libs.

Added --enable-static=no

> 3. Many of the *st scripts in /usr/share carry a broken SHEBANG and broken
> permissions.

I have fixed the boken shebangs. If a *.st file have a shebang, a+x will be set.

> 4. Please explain the purpose of the *-am.patch.
> In its core, the package renames the package (comprising the tarball's name!)
> and should not be applied. IMO this patch should not be applied.

I must refer you to comment #3 of this bug. The debian guys have change the
package name in the same way. I think, that a directory should be better named
/usr/share/gnu-smalltalk instead of '/usr/share/smalltalk'.

> 5. make check should be moved to %check

Done.

download:

SrPM: http://www.herr-schmitt.de/pub/gnu-smalltalk/gnu-smalltalk-2.2-6.src.rpm
SPEC: http://www.herr-schmitt.de/pub/gnu-smalltalk/gnu-smalltalk.spec

Best Regards:

Jochen Schmitt

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.