[Bug 177567] Review Request: smb4k - The SMB/CIFS Share Browser for KDE

bugzilla at redhat.com bugzilla at redhat.com
Wed Jan 11 23:27:07 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: smb4k - The SMB/CIFS Share Browser for KDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177567


gajownik at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gajownik at gmail.com




------- Additional Comments From gajownik at gmail.com  2006-01-11 18:26 EST -------
Hi!

I did not have time to take a closer look at this package but I found two problems:
- Missing builRequires: kdebase-devel. Without it compilation fails:

smb4k_konqplugin.h:28:31: error: konqsidebarplugin.h: No such file or directory

- “BuildRequires:	kdelibs-devel >= 3.2.0” -- it will not work as expected in
Fedora because kdelibs has “Epoch” tag set to “6”. You can change it to:

BuildRequires: kdelibs-devel >= 6:3.2

or remove “>= 6:3.2” part completely. FE is only for FC3+ so it's always true.

BTW You may want to add “--disable-dependency-tracking --enable-final” to the
configure script (I see that Rex Dieter adds these flags to his KDE packages).

If no one will be willing to make a review, I can do that at the weekend.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list