[Bug 176542] Review Request: gnome-yum - GNOME interface for YUM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-yum - GNOME interface for YUM


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176542


chabotc at xs4all.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From chabotc at xs4all.nl  2006-01-12 16:38 EST -------
Missing build requires: gtkhtml2-devel (config fails without it)

(trying srpm from comment #12)
rpmlint isn't so happy either:
E: gnome-yum no-changelogname-tag
E: gnome-yum zero-length /usr/share/doc/gnome-yum-0.1.2/README
W: gnome-yum no-dependency-on usermode-consoleonly
E: gnome-yum non-executable-script /usr/share/gnome-yum/gyum-query.sh 0644
E: gnome-yum zero-length /usr/share/doc/gnome-yum-0.1.2/NEWS
W: gnome-yum non-conffile-in-etc /etc/pam.d/gnome-yum
E: gnome-yum zero-length /usr/share/doc/gnome-yum-0.1.2/TODO
W: gnome-yum non-conffile-in-etc /etc/security/console.apps/gnome-yum

Changelog is just completely missing .. shouldn't be :-)

Empty file warnings are easy to fix, just leave them out :-) The non-executable,
maybe a root,755,root %attr for it? 

The warning about the non conf file can be ignored, since it is a config file 

I see the spec file uses:
[ -n "$RPM_BUILD_ROOT" -a "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
This was a standard (a good while ago) but the current guidelines say to just
use: rm -rf $RPM_BUILD_ROOT

If no one else has stepped up for review yet, i'll be willing too, changing
blocker to FE-REVIEW. Fix the issues mentioned in the comments (including this
one :-)) and once thats done i'll do the full review

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.