[Bug 177584] Review Request: zaptel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: zaptel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177584





------- Additional Comments From fedora at leemhuis.info  2006-01-13 11:37 EST -------
(In reply to comment #6)
> Hmm... the install section of the Makefile would require *EXTREME* surgery. 

Really? I took a quick look. From a first glance I would presume that removing
everything between
- if [ -f zaptel.ko ]; then \
and
- fi
should be enough.

> Unless it's going to block approval of the package 
I'm not the reviewer. But if was I would consider it a blocker.

> I'd rather install the files
> that I need manually in the spec until the upstream package gets fixed.
I did something like that in the past -- you have to recheck after each upstream
update that you still install everything exactly as the makefile would do it.
And that is a lot of work and often is forgotten (and that's the reason why I
think it's a blocker). 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.