[Bug 177635] Review Request: libtorrent
bugzilla at redhat.com
bugzilla at redhat.com
Sat Jan 14 18:38:18 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libtorrent
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177635
j.w.r.degoede at hhs.nl changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |j.w.r.degoede at hhs.nl
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From j.w.r.degoede at hhs.nl 2006-01-14 13:38 EST -------
The formal review steps:
MUST review items:
- Builds cleanly on FC5 devel.
- rpmlint has no output / complaints
- Source included matches upsteam source (md5sum)
- Package name meets guidelines
- spec file name is in %{name}.spec format
- Licence (GPL) is fedora extra's compatible & is included in spec
- Spec file is in (american) english
- Does not list buildrequires that are excepted in the package guidelines
- All build dependencies are listed
- Proper use of ldconfig
- All files have proper permissions
- Package is not relocatable
- No duplicate files in %files section
- No missing files in %files section
- Has a proper %clean section with rm -rf $RPM_BUILD_ROOT
- Uses macro's described in PackagingGuidelines
- No entries in %doc that are required for standard program operation
- Proper -devel package
- No .la files
- Package owns directories properly
Should items:
- Includes upstream licence file (COPYING)
- No insane scriplets, or scriplets at all
- No unnescesarry requires
Looks good to me, changing blockerbug to FE-ACCEPT and assigning to me.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list