[Bug 165992] Review Request: Glide3-libGL - Glide3 OpenGL library for use with 3Dfx Voodoo 1 & 2 cards

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 16 20:53:29 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Glide3-libGL - Glide3 OpenGL library for use with 3Dfx Voodoo 1 & 2 cards


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165992


chabotc at xs4all.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chabotc at xs4all.nl  2006-01-16 15:53 EST -------
Final official review:

MUST review items:
- Builds cleanly on FC5 devel.
- rpmlint output:
W: Glide3-libGL invalid-license MIT/X11
But this is ignorable, licence is compatible, it just doesn't recognise it
- Source included matches upsteam source (md5sum)
- Package name meets guidelines
- spec file name is in %{name}.spec format
- Licence (MIT/X11) is fedora extra's compatible & is included
in spec
- Spec file is in (american) english
- Does not list buildrequires that are excepted in the package guidelines
- All build dependencies are listed
- No ldconfig needed
- All files have proper permissions
- Package is not relocatable
- No duplicate files in %files section
- No missing files in %files section (only ships basic so & shell script)
- Has a proper %clean section with rm -rf $RPM_BUILD_ROOT
- Uses macro's described in PackagingGuidelines
- No entries in %doc that are required for standard program operation
- No -devel package needed (3d programs use standard libGL for -devel files)
- Proper directory-ownerships

Should items:
- Includes upstream licence file (licence.html)
- No insane scriplets
- No unnescesarry requires

FE-ACCEPTED

Hans please assign the bug to me, i don't have fedorabugs group access to do so
yet, import, make tag && make build and close this bug with NEXTRELEASE please.
Congrats on _finally_ getting it in after 3 months :-)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list