[Bug 177946] Review Request: xkeycaps : Graphical front end to xmodmap

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xkeycaps : Graphical front end to xmodmap


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177946





------- Additional Comments From chabotc at xs4all.nl  2006-01-16 16:18 EST -------
Thanks v2 looks good, formal reviewlist:

Review list MUST items:
- Builds cleanly on FC5 devel.
- rpmlint has no output / complaints
- Source included matches upsteam source (md5sum)
- Package name meets guidelines
- spec file name is in %{name}.spec format
- Licence (BSD-ish?) is fedora extra's compatible, included in 'man xkeycaps'
- Spec file is in (american) english
- Does not list buildrequires that are excepted in the package guidelines
- All build dependencies are listed
- No need for ldconfig
- All files have proper permissions
- Package is not relocatable
- No duplicate files in %files section
- No missing files in %files section
- Has a proper %clean section with rm -rf $RPM_BUILD_ROOT
- Uses macro's described in PackagingGuidelines
- No entries in %doc that are required for standard program operation
- No -devel package needed
- No directory-ownerships needed
- Includes desktop file, BR desktop-file-utils, installs using
desktop-file-install w/ proper vendor/category

Review list SHOULD items:
- No insane scriplets
- No unnescesarry requires

rpmlint has no complaints at all (no output)

However mock failed again; It has a missing libXext-devel BR.

Please if you have a faster machine then my notebook try mockbuilds your self
too to make sure your including all BR's properly? :-)

After adding that BR, rpmbuild -bs and a new mock build everything is peachy
perfect again. 

FE-APPROVED but based on the assumption you will add that BR before commiting to
CVS.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.