[Bug 176780] Review Request: wp_tray: A wallpaper utility that sits in the Notification Area
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jan 18 10:36:56 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: wp_tray: A wallpaper utility that sits in the Notification Area
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176780
chabotc at xs4all.nl changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From chabotc at xs4all.nl 2006-01-18 05:36 EST -------
Thanks update looks good.
Formal check list:
MUST review items:
- Builds cleanly on FC5 devel.
- rpmlint:
W: wp_tray non-standard-dir-in-usr libexec
(ignorable error, its the standard location for applets)
- Source included matches upsteam source (md5sum)
- Package name meets guidelines
- spec file name is in %{name}.spec format
- Licence (GPL) is fedora extra's compatible & is included
- Spec file is in (american) english
- Does not list BuildRequires that are excepted in the package guidelines
- All build dependencies are listed
- No ldconfig needed
- All files have proper permissions
- Package is not relocatable
- No duplicate files in %files section
- No missing files in %files section
- Has a proper %clean section with rm -rf $RPM_BUILD_ROOT
- Uses macro's described in PackagingGuidelines
- No entries in %doc that are required for standard program operation
- No -devel package needed
- No directory-ownerships needed
- Proper desktop file BR/installing
Should items:
- Includes upstream licence file (LICENSE)
- No insane scriplets
- No unnescesarry requires
- Mock builds correctly
Thanks for the updates, FE-APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list