[Bug 175433] Review Request: tor - Anonymizing overlay network for TCP (The onion router)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tor - Anonymizing overlay network for TCP (The onion router)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175433





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2006-01-18 12:18 EST -------
> I still see a file being created in the spec file:
> ...
> cat <<EOF >>src/config/torrc.sample.in

There won't be a file *created* but an existing one be modified. I do
not see how this can be done shorter or clearer with a separate SOURCE

> It uses a harcoded user/group id of 19...

Regarding the uid, please see
	  http://fedoraproject.org/wiki/PackageUserRegistry
	  http://fedoraproject.org/wiki/PackageUserCreation


> Actually, libevent is no longer statically linked. But it still
> needs a Requires:

An explicit  Requires: for libevent is not needed because of:
| $ rpm -qR tor
| ...
| libevent-1.1a.so.1  


> I dont think circular dependancies are cool...

Circular dependencies can not be avoided, Fedora Core is full of them
and rpm/smart/yum works fine with them. They are needed because:

a) tor needs some init-scripts
b) the init-scripts need the tor daemon

Because different init-methods are possible which bring in non-trivial
dependencies the init-scripts are in separate subpackages.


> source1 (the gpg signature) is defined but not used. it should
> probably either not be defined, or it should be used to actualy gpg
> check the source file in the prep stage.

It makes no sense to check the GPG signature in %prep. The buildsystem does
know neither the associated gpg key, nor does it define the trust. The
shipped GPG signature is for reviewers only who want to verify the tarball.


> Missing chkconfig --add / --delete in %post, %prun, %postun

The -lsb subpackage has the needed Requires(...): to register/unregister
the lsb initscript.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.