[Bug 178330] Review Request: Azureus - a BitTorrent Client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Azureus - a BitTorrent Client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178330


chabotc at xs4all.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |chabotc at xs4all.nl
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From chabotc at xs4all.nl  2006-01-19 11:04 EST -------
I'll pick it up, i'm almost getting used to this java packaging thing :-)
Changing to FE-REVIEW.

It builds cleanly on fedora-devel-i386, and functionally it seems well in order too.

However during compile i got this message:
/usr/bin/build-classpath: error: could not find xml-commons-apis Java extension
for this JVM
/usr/bin/build-classpath: error: All specified jars were not found

Is this a missing BuildRequires? Or an ignorable error? Doing "yum install
xml-commons-api" seemed to make it happy again, so it appears to be a missing
BuildRequire, if so please add it

Spacing in the header of the spec file is a little confused, seems your not
using spaces (especially for the patches) but tabs, in different editors this
then looks messy; Could you please re-indent it with spaces?

It might be better to: install -m644 %{SOURCE2} and 3 instead of copy, this way
your always sure the permissions are correct, and same with -m775 for the script

**** edit *** I see that you just corrected this in release 9 :-)

If you could please look at the above mentioned issues (spacing in header and
probable missing build requires) i'll post the formal reviewlist


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.