[Bug 178568] Review Request: lacewing Asteroid like game with may different ships

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lacewing Asteroid like game with may different ships


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178568





------- Additional Comments From paul at city-fan.org  2006-01-22 04:12 EST -------
(In reply to comment #4)
> rpmlint output:
> E: lacewing file-in-usr-marked-as-conffile /usr/share/lacewing/lacew.cfg

Given that this file basically just provides a set of default options, I would
either:
(a) not mark it as a config file, or
(b) move it to /etc
the idea being that /usr should be able to be mounted read-only. So if it's a
file that's expected to be edited at some time, it should go in /etc, and if not
it can stay in /usr but not be marked %config.

(In reply to comment #3)
> Under post and postun you have :
> 
> /usr/bin/gtk-update-icon-cache
> 
> I would change this to
> 
> %{_bindir}/gtk-update-icon-cache

I would advise against this. I used to do that sort of thing myself but was
convinced not to do so. The reason is that by keeping %{_bindir} etc. for use
only as targets for installation of files, someone can rebuild the package from
the SRPM and specify different destination directories, e.g.

$ rpmbuild --rebuild --define '_bindir /myapps' package.spec

and get the binaries installed where they want them. If you make changes like
the one suggested in comment #3, this will fail unless the package builder has
also installed gtk-update-icon-cache in the same place that they want to install
this package to. So I'd leave it as /usr/bin/gtk-update-icon-cache



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.