[Bug 178922] Review Request: asterisk - The Open Source PBX

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asterisk - The Open Source PBX


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178922


somlo at cmu.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |somlo at cmu.edu




------- Additional Comments From somlo at cmu.edu  2006-01-25 13:21 EST -------
> %{_sbindir}/asterisk
> %{_sbindir}/astgenkey
> %{_sbindir}/astman
> %{_sbindir}/autosupport
> %{_sbindir}/rasterisk
> %{_sbindir}/safe_asterisk
> %{_sbindir}/smsq
> %{_sbindir}/stereorize
> %{_sbindir}/streamplayer

You should probably do

%{_sbindir}/*

instead ?


> 
> %{_mandir}/man8/asterisk.8*
> %{_mandir}/man8/astgenkey.8*
> %{_mandir}/man8/autosupport.8*
> %{_mandir}/man8/safe_asterisk.8*

How about

%{_mandir}/man8/*

> 
> %defattr(-,asterisk,asterisk,-)
> 
> %dir %{_sysconfdir}/asterisk
> %config(noreplace) %{_sysconfdir}/asterisk/adsi.conf
> %config(noreplace) %{_sysconfdir}/asterisk/adtranvofr.conf
 ... <snip> ...
> %config(noreplace) %{_sysconfdir}/asterisk/zapata.conf

Enumerating all the conf files is rather and prone to omission when
something new gets added in a future version. You kind-of have to do it
here because you want postgres and odbc conf files in separate subpackages.

Here's a question for the more experienced packagers on the list: 
Is there a way to specify "all files in a directory *except* foo, bar,
and blah" ?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.