[Bug 179040] Review Request: socat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: socat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179040





------- Additional Comments From somlo at cmu.edu  2006-01-26 19:26 EST -------
Summary and %description should both start with a capital letter

> %setup -q -n "%{name}-%{mversion}"

use '%setup -q' and get rid of %{mversion}

> export DESTDIR=%{buildroot}
> %{__make} DESTDIR=%{buildroot} install

The 'export DESTDIR' line is redundant, unless you have a broken makefile.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.