[Bug 173499] Review Request: lagan: Local, global, and multiple alignment of DNA sequences

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lagan: Local, global, and multiple alignment of DNA sequences


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173499


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |jpmahowald at gmail.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2006-01-29 11:21 EST -------
Minor: Build has a bunch of  warning: ignoring return value of x, declared with
attribute warn_unused_result

Your patch sets the lagan dir but leaves the error messages that $LAGAN_DIR was
not set, although you don't use the env variables.

Good:

- rpmlint checks return:
W: lagan non-standard-dir-in-usr libexec
not too significant as per comment 1

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
(can remove commented R and BR lines if desired)
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.