[Bug 177104] Review Request: abook - Text-based addressbook program for mutt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abook - Text-based addressbook program for mutt


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177104





------- Additional Comments From wart at kobold.org  2006-01-29 19:19 EST -------
This isn't a formal review because I can't sponsor you, but here are a couple of
comments on the spec file:

* Consider if you want to use %{?dist} in the release line.  It's optional, but
many packagers find it useful.  This can also be added after importing into CVS.

* Please use the recommended value for BuildRoot per the packaging guidelines:
http://fedoraproject.org/wiki/Packaging/Guidelines

* Don't add the check for "/" in %clean.  Just remove $RPM_BUILD_ROOT with no
checks.  The BuildRoot: setting ensures that it won't be "/".

* rpmlint warnings:
W: abook non-standard-group Networking/Mail
Applications/Internet or Applications/Productivity might be more appropriate.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.