[Bug 171039] Review Request: geos

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 2 04:37:59 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geos


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171039





------- Additional Comments From rc040203 at freenet.de  2006-01-01 23:37 EST -------
(In reply to comment #3)

Package looks fine, except

> I haven't included any patches to geos-config as the baseline version looks OK
> and is consistent with the upstream version.
The geos-config scripts is broken:

geos-config --libs reports -L/usr/lib
geos-config --cflags reports -I/usr/include

Using -L/usr/lib and -I/usr/include in compiler calls breaks library rsp.
include search paths, and therefore is never correct.
(cf. pkg-config's behavior. It filters out -I/usr/include and -L/usr/lib).


Possible improvements to the spec:
* Append --disable-static to %configure and remove %exclude %{_libdir}/*.a
--disable-static prevents the package from building static libs and building
shared libs only (Should reduce the time required for building by almost 
factor 2)

* Consider to append --disable-dependency-tracking to %configure
This should speed up building the rpm significantly.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list