[Bug 176071] Review Request: silgraphite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: silgraphite


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176071





------- Additional Comments From mpeters at mac.com  2006-01-08 06:42 EST -------
I don't use YYYYMMDD (I did initially) because the svn release is a lot more
accurate.

The reviewer can do an svn co of the exact svn co used in the src.rpm and thus
can check against upstream with a diff.

It's also easier to report bugs upstream if the svn co revision is known.

I have no problem moving the svn to after the %{svn_rev} though.

With respect to placement of the dist tag - in this case it probably doesn't
matter because this package will not build on FC4 (dependencies not met), but if
the dist tag is before the alphatag - a build for an older distro won't ever
look newer to rpm. This could potentially be a problem if a newer svn release
fails to build in a newer core release, and the user upgrades. Having the
%{?dist} tag before the %{alphatag} means that yum would still upgrade the
package, even though the %{alphatag} was older, thus ensuring the user has a
package built against the right libraries.

That's my reasoning anyway. Again, it doesn't really matter that much for this
package since it requires rawhide anyway (due to fontconfig version).

There's also precedent for putting stuff after %{?dist}

foobar-3.fc3 foobar-3.fc4 foobar-3.fc5

Bug report for foobar in fc3 - bug does not affect fc4/fc5
When fixing the fc-3 issue, you would out a .1 - making it foobar-3.fc3.1 so
that you don't need to push useless updates in fc4/fc5

Essenstially that's what I'm doing - it's foobar-0.%{?dist} and the %{alphatag}
is equivalent to the .1

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.