[Bug 176780] Review Request: wp_tray: A wallpaper utility that sits in the Notification Area

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wp_tray: A wallpaper utility that sits in the Notification Area


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176780





------- Additional Comments From chabotc at xs4all.nl  2006-01-12 12:25 EST -------
First observations:
Package does build cleanly on FC5 devel

However filepermissions for the %doc files are 755, they should be 644. This
makes  rpmlint complain:
rpmlint  /usr/src/redhat/RPMS/i386/wp_tray-0.4.6-1.i386.rpm 
E: wp_tray script-without-shellbang /usr/share/doc/wp_tray-0.4.6/COPYING
E: wp_tray script-without-shellbang /usr/share/doc/wp_tray-0.4.6/ChangeLog
E: wp_tray script-without-shellbang /usr/share/doc/wp_tray-0.4.6/TODO
E: wp_tray script-without-shellbang /usr/share/doc/wp_tray-0.4.6/README
E: wp_tray script-without-shellbang /usr/share/doc/wp_tray-0.4.6/AUTHORS
E: wp_tray script-without-shellbang /usr/share/doc/wp_tray-0.4.6/NEWS

The icons for displaying in the gnome menu seem to be missing, though the
desktop file has:
Icon=/usr/share/pixmaps/wp_tray/

There's no such directory / files in the build package.

The configuration dialog seems to be nothing but a glade template with no
functional code, none of the buttons do anything, only way to close it is by
clicking the [X] window icon

The 'wallpaper search too' seems to be just as function-less as the config dialog.

The URL to the home page gives a 404, should probably read:
http://planetearthworm.com/projects/wp_tray/index.php

The Source0: tag should really use atleast %{version}, so it auto updates with
version updates. Also the download link is (now) invalid, the line should read
something like:
Source0: http://planetearthworm.com/projects/wp_tray/files/%{name}-%{version}.tar.gz

Much newer upstream version is available (0.5.1), might be worth updating? It
seems to address the non-working dialogs among other things.

New upstream version does have a lot of new/different requirements. I think to
satisfy its new requirements you'd probably need:
BuildRequires:  libglademm24-devel libgnomecanvasmm26-devel gconfmm26-devel
libgnomemm26-devel libgnomeuimm26-devel          
Requires:       libglademm24 libgnomecanvasmm26 gconfmm26 libgnomemm26
libgnomeuimm26          

Which are present in atleast fedora-extras-development (haven't checked for FC4,
but should be)

What else you'd need is the boostfilesystem libraries, which unfortunatly are
not packaged for Fedora Extra's yet (though feel free to :-)) which i think are
located at: http://www.boost.org/

If you make your way thru all of that i'd be happy to give a formal review

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.