[Bug 176981] Review Request: itext - a PDF creation library in java

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: itext - a PDF creation library in java


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176981





------- Additional Comments From green at redhat.com  2006-01-13 07:33 EST -------
(In reply to comment #1)
> A few questions/comments before doing a full review:

Thanks for having a look and sorry for the delay.  I have been travelling.

> 1) What's the purpose of the section define at the top of the spec file?  I'm
> assuming it's somehow related to jpackage...

Yes, this package has been borrowed from the JPackage Project with minimal
changes.  The JPackage provides both Free and non-Free Software packages.  This
is how they indicate which section the package belongs to.  I can remove this
from the FE package, but my goal was to make as few changes as possible in order
to ease merging down the road.

> 2) We tend to avoid doing, eg, jpp or the like in release tags

All of the packages in Fedora Core that have are derived from JPackage Project
packages have jpp in the release tag.  I'm not sure I agree that it's a good
idea, but I was just following FC existing practice.

> 3) Using %{summary}. for summaries is odd -- that doesn't describe what the
> purpose of the subpackage is.  Also, you'll end up with double periods like that

I agree.  I'll fix that and submit the fix to the JPackage project as well.

> 4) You shouldn't need the javadoc %postun as that should get handled by the fact
> that the file is ghosted.

Ok, same with this.

Thanks - I'll post a new package shortly.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.