[Bug 174504] Review Request: wine-docs - Documentation for wine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wine-docs - Documentation for wine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174504





------- Additional Comments From triad at df.lth.se  2006-01-13 17:10 EST -------
Lint results:

# rpmlint wine-docs-0.9.5-1.src.rpm
E: wine-docs configure-without-libdir-spec
- could be ignored, nothing libbed here.

# rpmlint wine-docs-0.9.5-1.noarch.rpm
W: wine-docs no-version-in-last-changelog

That thing again. Not much to care about here.

Docs are placed in /usr/share/doc/wine-docs-0.9.5, perhaps
one would prefer /usr/share/doc/wine-0.9.5 but who cares.

GOOD:
* Package name matches spec file name
* Meets package naming guidelines (child package docs)
* FLOSS-compatible license (LGPL)
* spec file is in american english
* spec file is readable indeed
* sources match upstream (MD5SUM is the same)
* builds fine on FC4
* no exceptionized BuildRequires
* all build dependencies listed
* no locale magic needed
* no libraries installed
* non-relocatable
* owns its directories (implicit since %doc tag is used)
* no duplicate files
* proper permissions on files
* proper %clean section
* proper use of macros I think, should %configure be used instead of ./configure?

NEEDSWORK:
* License field is wrong: tagged GPL but is LGPL (COPYING.LIB)
* The license file MUST be %doc:ed

Fix these and it's a go...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.