[Bug 177782] Review Request: byzanz - A desktop recorder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: byzanz - A desktop recorder


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177782


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-01-16 17:03 EST -------
Here's a review:

ok MUST items:

ok - MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
ok - MUST: The package must be named according to the PackageNamingGuidelines.
ok - MUST: The package must meet the PackagingGuidelines.
ok - MUST: The package must be licensed with an open-source compatible license...
GPL, good.
ok - MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
ok - MUST: The License field in the package spec file must match the actual license.
ok - MUST: The spec file must be written in American English.
ok - MUST: The spec file for the package MUST be legible.
ok - MUST: The sources used to build the package must match the upstream source
3c57cd11aba49fe05f77709cd9a7d609  byzanz-0.0.3.tar.gz
ok - MUST: A package must not contain any BuildRequires that are listed in the
exceptions section of PackagingGuidelines.
ok - MUST: All other Build dependencies must be listed in BuildRequires.
ok - MUST: The spec file MUST handle locales properly.
ok - MUST: A package must not contain any duplicate files in the %files listing.
ok - MUST: Permissions on files must be set properly.
ok - MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}...
ok - MUST: Each package must consistently use macros...
ok - MUST: The package must contain code, or permissable content.
ok - MUST: If a package includes something as %doc, it must not affect the
runtime of the application....
ok - MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.

Builds ok under devel.
Doesn't build on fc4 due to modular X and unavailable gnome packages,
I assume it's just targeted at devel and beyond.

NEEDINFO MUST items:

1 - MUST: A package must own all directories that it creates.

filesystem package owns /usr/libexec. I guess it's safe to assume filesystem is
installed, but
perhaps it should have a explicit requires for it?

2 - MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. This is described in detail in the desktop files section of
PackagingGuidelines. If you feel that your packaged GUI application does not
need a .desktop file, you must put a comment in the spec file with your explanation.

Should this package have a .desktop file since it's got a applet?

3 - MUST: rpmlint must be run on every package. The output should be posted in
the review.

Some rpmlint output:

W: byzanz summary-ended-with-dot A desktop recorder.
Should remove . on the end of summary.

W: byzanz non-standard-dir-in-usr libexec
I guess this can be ignored, but see note 1 above.

SHOULD Items:

ok - SHOULD: The reviewer should test that the package builds in mock.
4 - SHOULD: The package should compile and build into binary rpms on all
supported architectures.

I only have a x86 test box. I assume it will build ok on other arches.

5 - SHOULD: The reviewer should test that the package functions as described. ...

I am getting a segfault when I run the application on my devel test machine.
I was running inside a vnc session, but tried both Xfce and gnome.
(I don't have a monitor on my test box right at the moment).

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1211094112 (LWP 23477)]
0x0804d966 in gifenc_quantize_image (
    data=0xb7301800
"I\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\t"...,
width=1024, height=768, bpp=2, rowstride=2048, alpha=1,
    byte_order=1234, max_colors=255) at quantize.c:383
383           GIFENC_READ_TRIPLET (color, row);
(gdb) where
#0  0x0804d966 in gifenc_quantize_image (
    data=0xb7301800
"I\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\tI\t"...,
width=1024, height=768, bpp=2, rowstride=2048, alpha=1,
    byte_order=1234, max_colors=255) at quantize.c:383
#1  0x0804bb62 in byzanz_recorder_run_encoder (data=0x8253ed0)
    at byzanzrecorder.c:442
#2  0x0070f2a4 in g_thread_create_full () from /usr/lib/libglib-2.0.so.0
#3  0x009bf262 in start_thread () from /lib/libpthread.so.0
#4  0x0062c14e in clone () from /lib/libc.so.6

Let me know if I can provide any more information on tracking the segfault down. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.