[Bug 176981] Review Request: itext - a PDF creation library in java

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: itext - a PDF creation library in java


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176981





------- Additional Comments From green at redhat.com  2006-01-16 19:39 EST -------
(In reply to comment #4)
> Picking this one up on green's request, changing to FE-REVIEW. Green please
> assign the bug to me?

Done.  New versions of the files are here:

Spec Name or Url: http://people.redhat.com/green/FE/devel/itext.spec
SRPM Name or Url: http://people.redhat.com/green/FE/devel/itext-1.3-1jpp_4.src.rpm

> W: itext-javadoc dangerous-command-in-%post rm
> %post javadoc does confuse me, the scripplet:
>   rm -f %{_javadocdir}/%{name}                                                 
>                           
>   ln -s %{name}-%{version} %{_javadocdir}/%{name}
> 
> What are you trying to do here, isn't there a way to get the file locations
> correct in the %install without doing dangerous rm's and confusing links (with
> then not-owned) to directories? On removing this package this will result into a
> dead link

This was copied from the JPackage version of this package.  I just removed the
unversioned directory to avoid this whole problem.

> Would it maybe be an idea to combine the javadoc and manual packages? Normally
> documentation is in the -devel package, but seeing how this has none thats not
> an option. However having 2 'doc' packages seems a bit to much to me (but i have
> no inside knowledge of these docs, so if there are very good reasons then thats
> acceptable, but please put them in a comment in the specfile please)

I'm not sure if there is a good reason.  This is just standard practice for
JPackage packages.  javadoc always goes in its own package.

Thanks!

AG


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.