[Bug 176981] Review Request: itext - a PDF creation library in java

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: itext - a PDF creation library in java


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176981





------- Additional Comments From green at redhat.com  2006-01-16 21:03 EST -------
New files are here:
Spec Name or Url: http://people.redhat.com/green/FE/devel/itext.spec
SRPM Name or Url: http://people.redhat.com/green/FE/devel/itext-1.3-1jpp_5.src.rpm


(In reply to comment #6)
> Is it still worth having the %define section free in the spec file? Or is it
> there to keep it as close to the JPackage one as possible? Kind of looks out of
> place there :-)

I'm trying to make as few changes as possible, and will send those changes I
make back to the JPackage maintainer for itext.

> Licence is often written as 'MPL' and not fully "Mozilla Public Licence" (just
> as GPL/BSD/LGPL etc are written shorthand), mozilla its self uses MPL too so i
> think thats the example to follow, also by examples of other packages i think
> the proper format would be: MPL/LGPL

Ok.

> Still one inconsitent version in the changelog according to rpmlint:
> W: itext incoherent-version-in-changelog 0:1.3-1jpp_4 1.3-1jpp_4

I can't make this one go away (although now it says _5).

> rpmlint Group warnings:
> W: itext-javadoc non-standard-group Development/Documentation
> W: itext-manual non-standard-group Development/Documentation
> Its either Development/Libraries, or "Documentation", Development/Documentation
> unfortunatly doesn't exist. Please use "Documenation" for the 2 sub packages
> with the docs.

Fixed.

> other rpmlint warning:
> W: itext-manual hidden-file-or-dir /usr/share/doc/itext-1.3/ant/.ant.properties
> But this is ignorable 
> 
> The package also owns / inclues:
> /usr/share/java/itext
> But this is an empty directory .. is there any reason for its being there? If
> not please remove

Removed.

Thanks!

AG


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.