[Bug 176981] Review Request: itext - a PDF creation library in java

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: itext - a PDF creation library in java


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176981


chabotc at xs4all.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chabotc at xs4all.nl  2006-01-17 05:20 EST -------
rpmlint is now completely quiet, not a single warning or error :-) All the
mentioned above issues have been addressed.

Formal review list:

MUST review items:
- Builds cleanly on FC5 devel.
- Source included matches upsteam source (md5sum)
- Package name meets guidelines
- spec file name is in %{name}.spec format
- Licence (MPL/LGPL) is fedora extra's compatible & is included
- Spec file is in (american) english
- Does not list buildrequires that are excepted in the package guidelines
- All build dependencies are listed
- No ldconfig needed
- All files have proper permissions
- Package is not relocatable
- No duplicate files in %files section
- No missing files in %files section
- Has a proper %clean section with rm -rf $RPM_BUILD_ROOT
- Uses macro's described in PackagingGuidelines
- No entries in %doc that are required for standard program operation
- No -devel package needed (though using javadoc/manual packages there not devel
packages with .a/.so/.h files)
- No directory-ownerships needed
- No gui app, so no need for a desktop file

Should items:
- Includes upstream licence(s) file (MPL-1.1.txt and lgpl.txt)
- No insane scriplets
- No unnescesarry requires
- Mock builds cleanly now too

Great work! FE-APPROVED!

When you have cvs-import'ed, make tag && make build this package please close
the bug with NEXTRELEASE as resolution (and now you can import rssowl too and do
the same for it as soon as this is done building/being pushed to extras-development)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.