[Bug 177993] Review Request: fetchlog - displays the last new messages of a logfile

bugzilla at redhat.com bugzilla at redhat.com
Tue Jan 17 10:26:42 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fetchlog - displays the last new messages of a logfile


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177993





------- Additional Comments From chabotc at xs4all.nl  2006-01-17 05:26 EST -------
Builds cleanly on fedora-devel-i386 and in mock

Spec file does have one miror format inconsitency, we 'always' put the %doc line
just below the %defattr line, and not after the binary

Also one error in the spec file, the mandir for "man 1 foo" is
%{_mandir}/man1/foo and not %{_mandir}/1/foo; In the spec file you have:
%install:
install -d %{buildroot}/%{_mandir}/1
install -m644 %{name}.1 %{buildroot}/%{_mandir}/1
%files:
%{_mandir}/*/*

Should be:
%install:
install -d %{buildroot}/%{_mandir}/man1
install -m644 %{name}.1 %{buildroot}/%{_mandir}/man1

rpmlint is quiet and has no output.

The %install section is missing as first line:
rm -rf %{buildroot}

Its customary (and according to standards) to include this.

Formal review list:

MUST review items:
- Builds cleanly on FC5 devel.
- Source included matches upsteam source (md5sum)
- Package name meets guidelines
- spec file name is in %{name}.spec format
- Licence (GPL) is fedora extra's compatible & is included
- Spec file is in (american) english
- Does not list BuildRequires that are excepted in the package guidelines
- All build dependencies are listed
- No ldconfig needed
- All files have proper permissions
- Package is not relocatable
- No duplicate files in %files section
- No missing files in %files section (but does have a lost manpage)
- Has a proper %clean section with rm -rf $RPM_BUILD_ROOT
- Uses macro's described in PackagingGuidelines
- No entries in %doc that are required for standard program operation
- No -devel package needed
- No directory-ownerships needed
- No gui app, so no need for a desktop file

Should items:
- Includes upstream licence file (LICENSE)
- No insane scriplets
- No unnescesarry requires
- Mock builds correctly

Please address the above mentioned few minor errors and post a new srpm and i'll
do the formal review checklist again.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list