[Bug 177993] Review Request: fetchlog - displays the last new messages of a logfile

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fetchlog - displays the last new messages of a logfile


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177993


chabotc at xs4all.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chabotc at xs4all.nl  2006-01-17 20:18 EST -------
Guess other people never noticed, or aren't as perfectionistic as me, first spec
file i've seen in fedora with doc not bellow defattr, but its definatly not a
blocker, just matter of taste i guess :-)

Manpage and clean section are conform standards now too, still builds and mocks
cleanly too.

Formal check list:

MUST review items:
- Builds cleanly on FC5 devel.
- Source included matches upsteam source (md5sum)
- Package name meets guidelines
- spec file name is in %{name}.spec format
- Licence (GPL) is fedora extra's compatible & is included
- Spec file is in (american) english
- Does not list BuildRequires that are excepted in the package guidelines
- All build dependencies are listed
- No ldconfig needed
- All files have proper permissions
- Package is not relocatable
- No duplicate files in %files section
- No missing files in %files section
- Has a proper %clean section with rm -rf $RPM_BUILD_ROOT
- Uses macro's described in PackagingGuidelines
- No entries in %doc that are required for standard program operation
- No -devel package needed
- No directory-ownerships needed
- No gui app, so no need for a desktop file

Should items:
- Includes upstream licence file (LICENSE)
- No insane scriplets
- No unnescesarry requires
- Mock builds correctly

Thanks for the updates, FE-APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.