[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 177082] Review Request: wm-icons

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wm-icons


------- Additional Comments From luya_tfz thefinalzone com  2006-01-25 13:10 EST -------
+ mock succesfully build the source RPM

- Source0 should list the full path of URL: %{name}-%{version}.tar.bz2 should
be, for example, http://wm-icons.sourceforge.net/%{name}-%{version}.tar.bz2

- Changelog has a typo: 
" * Fri Jan 06 2006 James Lawrence <fedorajim gmail com> 0.4.0-3.FC4
- modified spec file removed FC4 from release line "
You mean version 0.3.0-3?

- rpmlint generated these errors:
W: wm-icons non-standard-group X11/Window Managers
W: wm-icons incoherent-version-in-changelog 0.4.0-3.FC4 0.3.0-3
E: wm-icons no-binary
W: wm-icons symlink-should-be-relative /usr/share/icons/wm-icons/menu
E: wm-icons zero-length /usr/share/icons/wm-icons/16x16-kde/_symlinks.lst
W: wm-icons symlink-should-be-relative /usr/share/icons/wm-icons/norm
E: wm-icons standard-dir-owned-by-package /usr/share/icons
W: wm-icons devel-file-in-non-devel-package /usr/bin/wm-icons-config
W: wm-icons symlink-should-be-relative /usr/share/icons/wm-icons/mini

Could you make sure to do both md5sum and sha1sum on source tarball for both
SRPM and the downloaded tarball you received? These methods are used for
security process.

Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]