[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 178951] Review Request: modules - Provides dynamic modification of a user's environment



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: modules - Provides dynamic modification of a user's environment


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178951


ed eh3 com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk redhat com              |ed eh3 com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From ed eh3 com  2006-01-27 22:38 EST -------
Hi Orion, I really don't know what to say in regards to the default
initialization of modules.  Some may view it as helpful while others 
may think its an annoyance.  Since you're packaging it, I think you 
should get some leeway in deciding whats appropriate.

And heres a quick review:

good:
 + source matches upstream
 + specfile is legible and looks sane
 + license is correct (GPL) according to the upstream web 
     site but no license is included in the source
 + builds in mock on FC4
 + permissions and dir ownership look OK
 + code not content

nits:
 - Why the "--disable-versioning" flag?  IMHO, its a pretty 
   cool and useful feature.

 - Please consider naming the package "environment-modules" 
   instead of just "modules" since it is the upstream project 
   name (the "Environment Modules Project") and its a lot less 
   ambiguous.  The name "modules" gets used for all sorts of 
   stuff including kernel modules and perhaps a more descriptive 
   name can help avoid some confusion for new users?  Its just 
   a suggestion, though.

 - rpmlint reports:

E: modules script-without-shellbang /usr/share/Modules/init/tcsh
E: modules script-without-shellbang /usr/share/Modules/init/bash
W: modules hidden-file-or-dir /usr/share/Modules/init/.modulespath
E: modules script-without-shellbang /usr/share/Modules/init/.modulespath
E: modules script-without-shellbang /usr/share/Modules/init/csh
E: modules script-without-shellbang /usr/share/Modules/init/zsh
E: modules script-without-shellbang /usr/share/Modules/init/python
E: modules script-without-shellbang /usr/share/Modules/init/perl
E: modules script-without-shellbang /usr/share/Modules/init/sh
E: modules script-without-shellbang /usr/share/Modules/init/ksh

   but I agree that these can probably be safely ignored

 - Please consider either adding the paper:

     http://modules.sourceforge.net/docs/MC2_whitney_paper.pdf

   to the documentation or adding a brief REAME-style link to 
   the homepage and the paper since its very helpful and well-
   written document.  Exactly the sort of thing new users should 
   read!



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]