[Bug 177580] Review Request: lat (LDAP Administration Tool)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lat  (LDAP Administration Tool)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177580





------- Additional Comments From wart at kobold.org  2006-01-29 19:56 EST -------
This isn't a formal review because I can't sponsor you, but just a few comments
from browsing the spec file:

* In %install and %clean, don't add the check for "/".  The use of BuildRoot:
ensures that it won't delete your entire hard drive.

* Add a period at the end of the %description.

* Include the full URL to the Source: archive, not just the filename.  The Url:
tag should be the Url to the package's home page, not the source tarball.

* Consider using %{?dist} in the Release: tag.  Many packagers find it useful.

* A couple of warnings appeared during the build that caused some missing file
errors; it looks like something wasn't obeying $(DESTDIR) in the Makefile.
scrollkeeper-update -p /var/tmp/lat-0.8.2-root/var/scrollkeeper -o
/var/tmp/lat-0.8.2-root/usr/share/omf/lat
Cannot stat file: /usr/share/gnome/help/lat/C/lat.xml : No such file or directory
Cannot write to log file: /var/log/scrollkeeper.log : Permission denied
Cannot write to log file: /var/log/scrollkeeper.log : Permission denied
...
error: File not found: /var/tmp/lat-0.8.2-root/var/scrollkeeper/index/0
error: File not found: /var/tmp/lat-0.8.2-root/var/scrollkeeper/TOC/0



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.