[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 178568] Review Request: lacewing Asteroid like game with may different ships



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lacewing Asteroid like game with may different ships


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178568


wart kobold org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From wart kobold org  2006-01-29 21:04 EST -------
MUST items:
* rpmlint output is clean
* package and spec name matches upstream
* GPL license valid, matches upstream, license file included
* Meets packaging guidelines
* Spec file is legible and in Am. English.
* Source matches upstream (md5sum ok)
* Builds cleanly on FC5 i386
* Valid BR; none are redundant
* No lang files; no shlibs.
* Package not relocatable
* 0wns all directories that it creates
* File permissions ok
* %clean looks good
* code, not content
* minimal doc files, do not affect runtime
* no -devel package necessary
* desktop file installed correctly

SHOULD items:
* package includes license fie
- mock build not tested, but did build fine on FC5.
* Package runs and causes loss of productivity.  :)

MUSTFIX:
* typo in the Summary:  'may' -> 'many'
* Leave out the phrase "Quoting from the webpage" from the description.  It
  seems excessive.

SHOULDFIX (won't block approval):
* consider splitting the data files and the program into separate packages.
  This will allow you to make smaller updates to fix problems with the code
  without requiring users to download the unchanged data files again (~135k
  vs. 635k download)

Since there have been no addtional comments about the use of %{_bindir} in the
pre/post scripts, and since they match the guidelines, I'm willing to leave them
as-is.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]