[Bug 177567] Review Request: smb4k - The SMB/CIFS Share Browser for KDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: smb4k - The SMB/CIFS Share Browser for KDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177567





------- Additional Comments From gajownik at gmail.com  2006-01-30 17:58 EST -------
Here's the review:

- rpmlint errors:

[y4kk0 at X i386]$ rpmlint smb4k-*
W: smb4k dangling-relative-symlink /usr/share/doc/HTML/en/smb4k/common ../common
W: smb4k-devel no-documentation
[y4kk0 at X i386]$

They can be disregarded.
- proper licence (GPL)
- source matches upstream

--- Things that should be fixed ---
Change

%{_datadir}/apps/konqsidebartng/

to

%{_datadir}/apps/konqsidebartng/add/smb4k_add.desktop

because:

[y4kk0 at X tmp]$ rpm -qf /usr/share/apps/konqsidebartng/add/
kdebase-3.5.0-2
[y4kk0 at X tmp]$

This also applies to:

%{_datadir}/icons/crystalsvg/*

[y4kk0 at X tmp]$ rpm -qf /usr/share/icons/crystalsvg/16x16
kdelibs-3.5.0-5
[y4kk0 at X tmp]$

This should be changed to:

%{_datadir}/icons/crystalsvg/*/apps/smb4k.png

Package is approved but you must correct these two glitches.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.