rpms/perl-Image-ExifTool/devel perl-Image-ExifTool-avoidtheworduse.patch, NONE, 1.1 perl-Image-ExifTool.spec, 1.5, 1.6

Jason L Tibbitts III tibbs at math.uh.edu
Tue Jul 11 15:24:51 UTC 2006


>>>>> "TC" == Tom Callaway <(spot) <fedora-extras-commits at redhat.com>> writes:

TC> Fix this package so it doesn't grab "perl(the)" as a false dep.

Wow, by patching out every instance of the word "use" in the source.

-        } elsif ($format eq 'int16u') {     # use the offset as the value
+        } elsif ($format eq 'int16u') {     # choose the offset as the value

Scary.  Which brings up a couple of questions:

*) Why not just use a dependency filter instead of hacking the source?
   That patch will have to be redone everytime the source changes.

*) Are of these changes are really necessary?  Surely the dependency
   generator skips PODs and comments.  I'd be truly concerned if it
   doesn't.

 - J<




More information about the fedora-extras-list mailing list