[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: rpms/poker-eval/FC-4 poker-eval.spec,1.8,1.9



On Fri, 2006-06-09 at 21:41 -0700, Christopher Stone wrote:
> On 6/9/06, Ralf Corsepius <rc040203 freenet de> wrote:
> > On Fri, 2006-06-09 at 21:29 -0700, Christopher Stone wrote:
> > > Modified Files:
> > >       poker-eval.spec
> > > -make install DESTDIR=%{buildroot}
> > > +%makeinstall
> >
> > Why the %makeinstall?  makeinstall is an anachronism and should only be
> > used if make DESTDIR=... install is nonfunctional.
> 
> Because it looks cleaner.
Simply stylishness ;)

>   What's wrong with using it?
%makeinstall overrides a set of environment variables during
"make install". I.e. it performs
make prefix="..." includedir="..." ...

It is error prone, can have effects inside of (broken) Makefiles and can
trigger rebuilds when executing "make install". If a package contains
libtool archives, it will cause broken *.la's being installed.
 

"make DESTDIR=... install" overrides a single environment variable and
is supposed to be specially designed for re-rooting installs to a
different installation root ($RPM_BUILD_ROOT) than the package has been
configured for ("/").

Exactly what you do during an rpm's %install.

Ralf




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]