[Bug 183292] Review Request: banshee

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: banshee


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183292


bdpepple at ameritech.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From bdpepple at ameritech.net  2006-03-02 12:11 EST -------
MD5Sums:
398b69c1818568b9d7a39c5e036de84b  banshee-0.10.6.tar.gz

Good:
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Package builds in Mock.
* Package installs and uninstalls cleanly on FC5.
* Make succeeds even when %{_smp_mflags} is defined
* Able to sync iPod ok.

Bad:
* Drop Duplicate BuildRequires:
      glib2-devel (by mono-devel),
      dbus-devel (by hal-devel),
      gtk2-devel (by libgnomeui-devel),
      GConf2-devel (by libgnomeui-devel),
      gnome-vfs2-devel (by libgnomeui-devel),
      libgnomeui-devel (by gnome-desktop-devel)
* Source URL isn't canonical. Should be
http://banshee-project.org/files/%{name}/%{name}-%{version}.tar.gz
* License is MIT, not GPL.
* Add COPYING file to package.
* Missing scriptlets & requires for GConf: refer to
http://fedoraproject.org/wiki/ScriptletSnippets#head-ff64cd482595764f672082d5a3b83e1fc22962e8
* Missing requires for desktop-file-utils needed desktop file mime update. 
Refer to
http://fedoraproject.org/wiki/ScriptletSnippets#head-d37d740d062d3aa6013aab44a79de88a6c1fe533
* Vender for desktop file should be Fedora.  Refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755
* rpmlint gives the following errors:

  W: banshee summary-not-capitalized easily import, manage, and play selections
from your music collection
  W: banshee no-documentation
  E: banshee standard-dir-owned-by-package /usr/share/icons
  W: banshee devel-file-in-non-devel-package /usr/lib/pkgconfig/banshee.pc
  E: banshee script-without-shellbang
/usr/lib/banshee/Banshee.Plugins/MMKeys.dll.config

It should be safe to ignore the error about the script-without-shellbang, since
that is mono specific.  The other error should be fixed though.

APPROVED, once these items are corrected.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.