[Bug 177104] Review Request: abook - Text-based addressbook program for mutt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abook - Text-based addressbook program for mutt


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177104


bugs.michael at gmx.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |bugs.michael at gmx.net
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From bugs.michael at gmx.net  2006-03-04 19:43 EST -------
Additionally:

* missing   rm -rf ${RPM_BUILD_ROOT}   as first line of %install

* missing   BuildRequires: gettext

* it defaults to running "lynx" as a textmode web browser,
  when not installed, the error message is not obvious, since it
  only flashes on the screen very briefly -- alternatively:
  Requires: lynx

* don't package in %doc the INSTALL file, since it is irrelevant and
  confusing to users of your package

* prefer   make DESTDIR=${RPM_BUILD_ROOT}   over %makeinstall macro
  unless the latter breaks


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.