[Bug 186813] Review Request: njam - Maze-game where you must eat all the dots and avoid the badguys

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 27 21:21:48 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: njam - Maze-game where you must eat all the dots and avoid the badguys


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186813


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-03-27 16:21 EST -------
MUST
====
* rpmlint complains about the setgid binary.  This is acceptable per
  the Games SIG recommendation regarding scoreboard files.
* Package and spec file named appropriately
* License (GPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
    231fda022d309e1ef4a0d993ca693462  njam-1.25-src.tar.gz
* Compiles and builds on FC5-i386 and in mock on FC4-x86_64, FC4-i386
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Permissions ok
* %doc does not affect runtime
* Contains code and permissible content
* No -devel package
* .desktop file included
* Directory ownership ok 

MUSTFIX
=======
* Some of the wording and capitalization in the %description is a little
  awkward.  I suggest the following:
"Njam is a fast-paced maze-game where you must eat all the cookies while
avoiding the badguys. Special cookies give you the power to freeze or eat the
bad guys. The game features single and multiplayer modes, network play,
duelling and cooperative games, great music and sound effects, customizable
level skins, many different levels and an integrated level editor." 

* Man pages for games should go in %{mandir}/man6 according to the FHS:
  http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES
  This also needs to be mentioned on the Games SIG wiki page (I'll add it
  shortly)

* The summary, %description, and njam.1 file should refer to cookies instead of
  dots.  This is how they are described on the home page.

RECOMMENDED
===========
* For a nicer looking icon, make the background transparent:
    convert -transparent black njamicon.ico %{name}.png

* The "Home" link in the upper-right of the doc-editor.html file points to
  a nonexistant index.html file.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the fedora-extras-list mailing list