[Bug 183290] Review Request: libipoddevice

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libipoddevice


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183290


bdpepple at ameritech.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bugzilla-sink at leemhuis.info |bdpepple at ameritech.net
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From bdpepple at ameritech.net  2006-03-01 19:13 EST -------
MD5Sums:
000b3c7b82026bf052a16811ba34c515  libipoddevice-0.4.1.tar.gz

Good:
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Package builds in Mock.
* Package installs and uninstalls cleanly on FC5.
* Make succeeds even when %{_smp_mflags} is defined
* Rpmlint does not find problems

Needs Work:
* Source URL isn't canonical. Should be
http://banshee-project.org/files/%{name}/%{name}-%{version}.tar.gz
* Refer to Comment #1, if planning to release for FC4.
* License is LGPL, not GPL.
* Add COPYING file to package.

Once these items are fixed, consider it approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.