[Bug 183291] Review Request: ipod-sharp
bugzilla at redhat.com
bugzilla at redhat.com
Thu Mar 2 15:31:10 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ipod-sharp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183291
bdpepple at ameritech.net changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From bdpepple at ameritech.net 2006-03-02 10:31 EST -------
MD5Sums:
734956f3505f776c6920d4ae687f4bee ipod-sharp-0.5.15.tar.gz
Good:
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* Builds fine in Mock (once missing BR (hal-devel) added to spec)
* Package installs and uninstalls cleanly on FC5.
* Make succeeds even when %{_smp_mflags} is defined
Bad:
* Missing Build Requirement for hal-devel
* Source URL isn't canonical. Should be
http://banshee-project.org/files/%{name}/%{name}-%{version}.tar.gz
* License is LGPL, not GPL.
* Add COPYING file to package.
* rpmlint gives the following errors:
E: ipod-sharp no-binary
E: ipod-sharp only-non-binary-in-usr-lib
W: ipod-sharp no-documentation
W: ipod-sharp devel-file-in-non-devel-package /usr/lib/pkgconfig/ipod-sharp.pc
W: ipod-sharp devel-file-in-non-devel-package /usr/lib/pkgconfig/ipod-sharp-ui.pc
Most of these errors can be ignored, or be easily corrected (like adding the
COPYING file). You should probably add a -devel sub-package to handle the *.pc
files, though.
APPROVED, once these items are corrected.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the fedora-extras-list
mailing list