[Bug 174440] Review Request: bakery - C++ framework for creating GNOME apps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bakery - C++ framework for creating GNOME apps


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174440


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2006-03-05 04:01 EST -------
Good:

- rpmlint checks return:

W: bakery-debuginfo objdump-failed
Executing objdump on this file failed, all checks could not be run.
Not critical

E: bakery-devel only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
False alarm, symlink.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- locales handled by %find_lang
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.