[Bug 183947] Review Request: R-waveslim - R package for wavelets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-waveslim - R package for wavelets


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183947





------- Additional Comments From tibbs at math.uh.edu  2006-03-07 00:18 EST -------
I like the package; contratulations on working up a specfile generator for R
packages.  Everything looks pretty good.  rpmlint says:

W: R-waveslim invalid-license GPL version 2 or newer
W: R-waveslim no-documentation

Good:
We have no standards for R package naming, but R-packagename is reasonable.
The specfile is clean and understandable.
The source matches upstream.
Package dependencies are sane.

Bad:
rpmlint doesn't like the License: tag.  No package in extras yet specifies the
acceptable GPL version; I would suggest just using GPL.  When GPLv3 is out I
suppose we'll have to be more specific.

rpmlint doesn't find any documentation.  Of course this package includes a pile
of documentation, but it's all incorporated into R's internal documentation
system.  The base R package doesn't list any of the internal documentation as
%doc so I don't think it would be reasonable to do so here.  This shouldn't be a
blocker, but if someone takes issue with it then the base R package needs some
work as well.

The package fails to build in mock:

* Installing *source* package 'waveslim' ...
** libs
gfortran   -fPIC  -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32
 -march=i386 -mtune=pentium4 -fasynchronous-unwind-tables -c bell-p-w.f -o
bell-p-w.o
make: gfortran: Command not found
make: *** [bell-p-w.o] Error 127
ERROR: compilation failed for package 'waveslim'
** Removing
'/var/tmp/R-waveslim-1.5-1.fc5-root-mockbuild/usr/lib/R/library/waveslim'
error: Bad exit status from /var/tmp/rpm-tmp.71138 (%install)

I believe you need a RuildRequires: gcc-gfortran.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.