[Bug 174883] Review Request: distcc -- A free distributed C/C++ compiler system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: distcc -- A free distributed C/C++ compiler system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174883





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2006-03-07 06:20 EST -------
* Mon Mar 06 2006 Enrico Scholz <enrico.scholz at informatik.tu-chemnitz.de> - 2.18.3-1.3
- added 'desktop-file-utils' BR
- moved the gnome icon the a common place
- added -server-xinetd subpackage
- added -server-ssh subpackage for ssh-setup
- added logrotate support

http://ensc.de/fedora/distcc.spec
http://ensc.de/fedora/distcc-2.18.3-1.3.src.rpm


===============


> W: distcc incoherent-version-in-changelog 2.18.3-0.6 2.18.3-1
>   The version your changelog refers to should be 2.18.3-1

ok, will be fixed (at least in the released version ;))


> W: distcc conffile-without-noreplace-flag /etc/profile.d/distcc.sh
>   As this is no config-file this warning seems to be ignorable
> 
> E: distcc executable-marked-as-config-file /etc/profile.d/distcc.sh
>   You should add distcc.sh separately not flagging it as a config.
>   This will make the warning above go away, too.

I removed the 'x' bit from the distcc.sh. But I think that it should
be marked as a simple %config: there should be no need to edit this
file but changes should not be lost silently.


> E: distcc script-without-shellbang /etc/profile.d/distcc.sh
>   "!#" is missing in your shellscript

The shellbang warning is bogus; the profile.d scripts will be source'd
but not executed.


> W: distcc dangerous-command-in-%preun rm
> W: distcc dangerous-command-in-%trigger ln
> W: distcc dangerous-command-in-%trigger rm
>   I don't know how dangerous this really is. Please check that.

should be ok...


> W: distcc-gnome non-standard-group Development/Applications
>   This should just be one of /usr/share/doc/rpm-4.?.?/GROUPS

is now Development/Tools


> W: distcc-server-lsb conffile-without-noreplace-flag /etc/rc.d/init.d/distccd
>   This is no config-file, don't flag it as such.

initscripts are usually marked as simple %config files (there should
be no need to edit them but changes should not be lost silently.)


> W: distcc-server-lsb no-documentation
>   The manpage for the server is missing: %{_mandir}/man1/distccd.1.gz

the -server subpackage has this man-page and this subpackage is required
by -server-lsb.


> E: distcc-server-lsb postin-without-chkconfig /etc/rc.d/init.d/distccd
> E: distcc-server-lsb preun-without-chkconfig /etc/rc.d/init.d/distccd
>   "chkconfig -add distccd" and "chkconfig -del distccd" is needed for 
>   correctly  un-/installing the server package

there ARE rules to register/unregister the service


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.