[Bug 184304] Review Request: quadkonsole

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 7 23:22:29 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: quadkonsole


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184304


orion at cora.nwra.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bugzilla-sink at leemhuis.info |orion at cora.nwra.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From orion at cora.nwra.com  2006-03-07 18:22 EST -------
Needs work:

$ rpmlint quadkonsole-2.0.1-1.src.rpm
E: quadkonsole description-line-too-long QuadKonsole is a program which embeds 4
Konsoles (other numbers can be specified

reformat to less than 80 chars.

- .desktop file:

  - add "X-KDE-StartupNotify=true" to the .desktop file
 

Good:

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles in mock for devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime


APPROVED with above changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the fedora-extras-list mailing list